[JENKINS-70560] Improve JVMMismatchClause test coverage

[code-arnab]

Improved Test Coverage of JVMVersionMonitor.JVMMismatchCause from 0% to 72%.

Added extensive test coverage for the getTrigger function in the JVMMismatchCause Class of the enclosing JVMVersionMonitor Class. This PR will improve the test coverage of the above said function from 0% to 72%, and overall the entire test coverage of this plugin is improved by 2% from 79% to 81%.

Before

After

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

Pull request needs to run mvn spotless:apply to retain the correct code formatting

[code-arnab]

Pull request needs to run mvn spotless:apply to retain the correct code formatting

Ah, I see. Thanks for the tip.

[code-arnab]

@MarkEWaite
"continuous-integration/jenkins/pr-head — This commit cannot be built"
Sorry, but did I missed something here?

[MarkEWaite]

@MarkEWaite
"continuous-integration/jenkins/pr-head — This commit cannot be built"
Sorry, but did I missed something here?

Click the "Details" link in the right hand column and it will open the failing job on ci.jenkins.io. It is failing because the code formatting does not match the automated code formatting and this plugin uses automated code formatting.

[MarkEWaite]

Closing and reopening the pull request won't change the problem that exists in the pull request. In order to fix the problem in the pull request, you need to run mvn spotless:apply on your local copy, then commit the changes that are created by that command and push the result. That will reduce the size of the diff and allow the job to pass.

[code-arnab]

I ran mvn spotless:apply but it is still failing. I guess I should create a fresh pr after running the command again

[MarkEWaite]

I ran mvn spotless:apply but it is still failing. I guess I should create a fresh pr after running the command again

No, you've discovered an error in the configuration of the plugin source code. Thanks for discovering it. Either you or I can add a new file ".gitattributes" to the root of the repository with the contents:

*.java text eol=lf
*.jelly text eol=lf
*.md text eol=lf
*.xml text eol=lf

That will tell git to always write line feed (LF) characters when it commits a change to a Java source file, a Jelly source file, a Markdown source file, or an XML source file. More information is available from the GitHub documentation.

Would you be willing to include that fix in this pull request or should I create a separate pull request to fix it ?

[code-arnab]

I ran mvn spotless:apply but it is still failing. I guess I should create a fresh pr after running the command again

No, you've discovered an error in the configuration of the plugin source code. Thanks for discovering it. Either you or I can add a new file ".gitattributes" to the root of the repository with the contents:

*.java text eol=lf
*.jelly text eol=lf
*.md text eol=lf
*.xml text eol=lf

That will tell git to always write line feed (LF) characters when it commits a change to a Java source file, a Jelly source file, a Markdown source file, or an XML source file.

Would you be willing to include that fix in this pull request or should I create a separate pull request to fix it ?

That's interesting. Sure, I'll be willing to make a commit for this.

[MarkEWaite]

Looks great! Thanks for improving the test coverage!

[code-arnab]

Looks great! Thanks for improving the test coverage!

Thank You very much for all the support!