Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to JENKINS-10730 plus appears to fix memory leaks #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Visual Source Safe - Jenkins plugin
===================================

[Jenkins](https://wiki.jenkins-ci.org/display/JENKINS/Visual+SourceSafe+Plugin) vss plugin

Created this fork primarily with the intention of fixing the polling bug. JENKINS-10730

In doing so, I tried upgrading the version of com4j which appears to work. I use this now at a client's
site and have not had to restart Jenkins due to a memory leak.

Building
========
Install [maven](http://maven.apache.org)

then in root of these files type:

mvn package

You should end up with `vss.hpi` inside the `target` directory which you can install in Jenkins as if
you had downloaded it manually.

I don't know how we go about getting this officially released as version 1.10? I don't want to be the
maintainer as I'm only using VSS for a particular client and _hopefully_ won't be using it in the
longer term.

8 changes: 6 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>1.424</version>
<version>1.466</version>
</parent>

<artifactId>vss</artifactId>
Expand All @@ -30,6 +30,10 @@
<developerConnection>scm:git:ssh://git@github.com/jenkinsci/vss-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/vss-plugin</url>
</scm>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

<dependencies>
<dependency>
Expand All @@ -40,7 +44,7 @@
<dependency>
<groupId>org.jvnet.com4j</groupId>
<artifactId>com4j</artifactId>
<version>20070717</version>
<version>20120426</version>
</dependency>
</dependencies>

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/scm/vss/VSSSCM.java
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ protected PollingResult compareRemoteRevisionWith(AbstractProject<?, ?> project,
{
//If this is the build then it deserves a build.
AbstractBuild<?, ?> lastBuild = (AbstractBuild<?,?>)project.getLastBuild();
if(lastBuild == null)
if(lastBuild != null)
{
tl.getLogger().println("[poll] Last Build : #" + lastBuild.getNumber());
}
Expand Down