Skip to content

Replace warnings plugin duplicate implementation of reference jobs with forensics plugin API #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Feb 23, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 4, 2024

Use the new reference job API of the forensics plugin. Remove the warnings plugin specific reference job implementations.

Downstream of jenkinsci/forensics-api-plugin#519

# Conflicts:
#	plugin/pom.xml
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/RecordIssuesStep.java
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/ScanForIssuesStep.java
#	plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/MiscIssuesRecorderITest.java
#	plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/StepsITest.java
# Conflicts:
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/model/StaticAnalysisLabelProvider.java
Remove the warnings plugin specific reference job implementation.
@uhafner uhafner added the enhancement Enhancement of existing functionality label Feb 4, 2024
@uhafner uhafner changed the title Reference job Use the new reference job API of the forensics plugin and remove warnings plugin duplicate implementations Feb 4, 2024
@uhafner uhafner changed the title Use the new reference job API of the forensics plugin and remove warnings plugin duplicate implementations Use the reference job API of the forensics plugin and remove warnings plugin duplicate implementations Feb 4, 2024
@uhafner uhafner changed the title Use the reference job API of the forensics plugin and remove warnings plugin duplicate implementations Replace warnings plugin duplicate implementation of reference jobs with forensics plugin API Feb 4, 2024
import static org.mockito.Mockito.*;

/**
* Tests the class {@link QualityGate}.
*
* @author Ullrich Hafner
*/
class QualityGateTest extends SerializableTest<QualityGate> {
class QualityGateTest extends SerializableTest<WarningsQualityGate> {

Check notice

Code scanning / CodeQL

Unused classes and interfaces

Unused class: QualityGateTest is not referenced within this codebase. If not used as an external API it should be removed.
@uhafner uhafner marked this pull request as ready for review February 23, 2024 20:50
@uhafner uhafner merged commit 58782cc into main Feb 23, 2024
@uhafner uhafner deleted the reference-job branch February 23, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant