Remove support for multiple WAR files #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winstone contains 100 or so lines of code for a
--webappsDir
switch to run a directory full of WAR files, each with their own request logger which logs requests to a different file. There are no references to this in thejenkinsci
,jenkins-infra
, andcloudbees
GitHub organizations. There is no test coverage for the feature. The single reference in Jira is JENKINS-5307, from 2010. While I am aware of people running Jenkins as a WAR file in Tomcat alongside other WAR files, I am not aware of anyone using Winstone to run multiple WAR files. I think it is quite likely there are zero people using this feature.This all is changing in Jetty 12, which now does request logging at a per-
Server
level, not a per-webapp level. Thus the current code would require significant changes to support the existing functionality. Since it has no test coverage, and since we think there are zero people using it, this PR removes the feature. That way, we won't have to port it to Jetty 12, and we also won't have to manually test the result.Proposed changelog and upgrade guide entries
The
--webappsDir
argument to run Winstone with a directory full of WAR files has been removed without replacement.Testing done
mvn clean verify