Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60409] --requestFormContentSize no longer works #95

Merged
merged 2 commits into from
Mar 5, 2020
Merged

[JENKINS-60409] --requestFormContentSize no longer works #95

merged 2 commits into from
Mar 5, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 4, 2020 •
edited
Loading

JENKINS-60409

Amending #20 because this feature stopped working after #68 in 5.4 with jetty/jetty.project#3899.

  • Reproduce problem in unit test
  • Fix
  • Verified in context:
  • run a Jenkins master build
  • install kubernetes plugin
  • add a K8s cloud
  • start adding pod templates and clicking Apply until the error is seen (once the Content-Length goes above 200_000)
  • apply
diff --git war/pom.xml war/pom.xml
index 3f816fb897..c5d0355ab1 100644
--- war/pom.xml
+++ war/pom.xml
@@ -100,7 +100,7 @@ THE SOFTWARE.
       -->
       <groupId>org.jenkins-ci</groupId>
       <artifactId>winstone</artifactId>
-      <version>5.8</version>
+      <version>5.9-rc529.8a8a146c88e5</version>
       <scope>test</scope>
     </dependency>
     <dependency>
  • run with this patched WAR
  • add some more pod templates and Apply to see that there is no error even past 200_000

oleg-nenashev
oleg-nenashev approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right. Thanks @jglick !

@jglick jglick mentioned this pull request Mar 4, 2020
Closed
@olamy olamy merged commit 57f9c64 into jenkinsci:master Mar 5, 2020
oleg-nenashev pushed a commit that referenced this pull request Mar 6, 2020
@olamy @oleg-nenashev
[JENKINS-60409] --requestFormContentSize no longer works (#95)
8048d2a 
* Reproduced problem in unit test

* Request.extractFormParameters no longer honor server attributes when a ContextHandler is defined
@jglick jglick deleted the largeForm-JENKINS-60409 branch March 6, 2020 14:07
@mawinter69 mawinter69 mentioned this pull request Jun 12, 2024
Open
@basil
Copy link
Member

basil commented Jun 12, 2024

Incomplete—see jenkinsci/maven-hpi-plugin#625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
bug regression-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jglick @basil @olamy @oleg-nenashev