Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Javadoc for fixing the pipeline #155

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

twasyl
Copy link
Contributor

@twasyl twasyl commented Jun 7, 2021

Working on #153, the pipeline failed due to some incorrect Javadoc syntax. Just trying to fix that so the pipeline is green on the step.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. The closing </p> are implied in most scenarios and aren't the source of errors. Note, you saw an error when you had <p><ul></ul></p> because the <ul> implicitly adds </p> before it.

@bitwiseman bitwiseman merged commit 14d7f72 into jenkinsci:master Jun 7, 2021
@twasyl twasyl deleted the javadoc-fixes branch June 8, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants