Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for icon removal from core #192

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jan 6, 2022

Preparation for core removing sunset icons: https://github.com/jenkinsci/jenkins/pull/5778

@car-roll

@NotMyFault NotMyFault force-pushed the chore/master/prep-for-icon-removal-from-core branch from e6f9460 to 7b1e0a5 Compare January 13, 2022 14:57
@car-roll
Copy link
Contributor

re-run not working

@car-roll car-roll merged commit 7a916f3 into jenkinsci:master Jan 15, 2022
@NotMyFault NotMyFault deleted the chore/master/prep-for-icon-removal-from-core branch January 15, 2022 10:05
@NotMyFault
Copy link
Member Author

Do you mind labeling this PR with 'enhancement' to let CD pick it up? That would complement well with https://github.com/jenkinsci/workflow-job-plugin/pull/221

@car-roll
Copy link
Contributor

I think just changing the label would only kick off CD for the next merge. I went ahead and just manually ran CD 🚀

@NotMyFault
Copy link
Member Author

Thanks 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants