Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize modern build status #199

Merged

Conversation

NotMyFault
Copy link
Member

The change proposed utilizes the modern build icons, like they are used in other parts of Jenkins.
The pom change bumps the baseline to the LTS version the change has been introduced in.

Before:

My proposed change:

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault
Copy link
Member Author

Mind taking a look @car-roll ?

@car-roll car-roll merged commit d1e01d8 into jenkinsci:master Feb 28, 2022
@NotMyFault NotMyFault deleted the feat/master/utilize-modern-build-status branch February 28, 2022 19:17
@NotMyFault
Copy link
Member Author

It looks like something went wrong that prevents CD to perform a release. The merge commit is stuck on building.

@car-roll
Copy link
Contributor

I'm merging in another PR that is ready, so let's see if that clears it up

@NotMyFault
Copy link
Member Author

I'm merging in another PR that is ready, so let's see if that clears it up

That seems to have resolved it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants