Make ErrorAction.equals a public API #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Jul 3, 2023
| @@ -165,7 +167,8 @@ public String getUrlName() { | |||
| * {@link Throwable#equals} might not be reliable if the program has resumed | |||
| * and stuff is deserialized. | |||
| */ | |||
| private static boolean equals(Throwable t1, Throwable t2) { | |||
| @Restricted(Beta.class) | |||
| public static boolean equals(Throwable t1, Throwable t2) { | |||
There was a problem hiding this comment.
For my particular case, I could instead create a new public static boolean isRethrown(FlowNode node) method that checks whether the ErrorAction on the associated FlowNode was also thrown by one of its immediate parents, but exposing equals directly does not seem particularly problematic to me and may be useful in other cases.
joseblas
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorAction.findOriginis useful, but can be prohibitively slow in complex Pipelines with a lot of errors, as it scans the entire flow graph. In particular, I have a case where I only need to know whether a specificErrorActionrepresents an original or re-thrown error, andfindOriginis currently the only way to get access to theErrorIdequality logic.This PR exposes
ErrorAction.equalsso that other plugins can check error originality using more limited scans in cases where finding the true origin of an error is unnecessary and too slow.Testing done
Submitter checklist