Add LogStorage
utility methods that expose the functionality of BufferedBuildListener
, DelayBufferedOutputStream
, and GCFlushedOutputStream
#297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogStorage
implementations that are similar toFileLogStorage
need to be able to use the same logic asBufferedBuildListener
,DelayBufferedOutputStream
, andGCFlushedOutputStream
for both performance and correctness reasons, so we should expose these classes' functionality.I think we can just add two methods to wrap a given
OutputStream
as needed without having to fully expose the classes. I am not sure what name would be best, feel free to recommend whatever you like.Testing done
Submitter checklist