Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h nested parallelism
dwnusbaum
commented
Sep 11, 2023
| @@ -1029,7 +1029,8 @@ public void inProgressParallelInParallel() throws Exception { | |||
| SemaphoreStep.waitForStart("innerA/1", b); | |||
| ForkScanner scanner = new ForkScanner(); | |||
| sanityTestIterationAndVisiter(b.getExecution().getCurrentHeads()); | |||
| assertBranchOrder(b.getExecution(), "innerB", "innerA", "outerC", "outerB", "outerA"); | |||
| // Observed to flake with innerA coming first in some cases. | |||
| // assertBranchOrder(b.getExecution(), "innerB", "innerA", "outerC", "outerB", "outerA"); | |||
There was a problem hiding this comment.
I think that the flakiness is just because the build was incomplete and the similar assertion a few lines below should be consistent. Not 100% sure though.
src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java
Show resolved
Hide resolved
jglick
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #306 (comment).
Testing done
Submitter checklist