-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-45693] Defined TaskListenerDecorator #76
[JENKINS-45693] Defined TaskListenerDecorator #76
Conversation
Otherwise when resuming a build you can get: … org.jenkinsci.plugins.workflow.support.pickles.TryRepeatedly$1 run WARNING: null java.io.IOException: java.io.IOException: not implemented at org.jenkinsci.plugins.workflow.log.BrokenLogStorage.overallListener(BrokenLogStorage.java:52) at org.jenkinsci.plugins.workflow.flow.FlowExecutionOwner.getListener(FlowExecutionOwner.java:130) at org.jenkinsci.plugins.workflow.support.pickles.TryRepeatedly$1.run(TryRepeatedly.java:96) at … Caused by: java.io.IOException: not implemented at org.jenkinsci.plugins.workflow.flow.FlowExecutionOwner$DummyOwner.getExecutable(FlowExecutionOwner.java:166) at io.jenkins.plugins.pipeline_log_fluentd_cloudwatch.PipelineBridge.forBuild(PipelineBridge.java:55) at org.jenkinsci.plugins.workflow.log.LogStorage.of(LogStorage.java:115) ... 10 more
…rogressive logging and node decorating in a reusable way.
Reverting the fix in jenkinsci/workflow-support-plugin@842ee5a reproduces the ISE. One root cause was fixed in jenkinsci/workflow-job-plugin@976c775.
…omplains about, causing bad display of logs from before upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to the upstream approval
Compare link for convenience: jglick/workflow-api-plugin@logs-JENKINS-38381...jglick:ConsoleLogFilter-JENKINS-45693 |
JENKINS-45693
Subsumes #17. See jenkinsci/workflow-support-plugin#72 & jenkinsci/workflow-job-plugin#105.