Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new JenkinsRule.showAgentLogs #88

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Using new JenkinsRule.showAgentLogs #88

merged 2 commits into from
Apr 3, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 2, 2019

Downstream of jenkinsci/plugin-pom#188.

@jglick jglick mentioned this pull request Apr 2, 2019
Merged
@jglick jglick requested a review from dwnusbaum April 2, 2019 18:39
batmat
batmat previously requested changes Apr 2, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code 😋

Same change request as in JTH.

Thanks!

@jglick jglick changed the title Using new JenkinsRule.showSlaveLogs Using new JenkinsRule.showAgentLogs Apr 2, 2019
@jglick jglick requested a review from batmat April 2, 2019 19:56
@jglick jglick dismissed batmat’s stale review April 2, 2019 19:58

addressed

@jglick jglick merged commit 9a38fc6 into jenkinsci:master Apr 3, 2019
@jglick jglick deleted the showSlaveLogs+JavaSpecificationVersion branch April 3, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @batmat @dwnusbaum