Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jakarta Mail #168

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Migrate to Jakarta Mail #168

merged 4 commits into from
Jul 19, 2022

Conversation

basil
Copy link
Member

@basil basil commented Jan 8, 2022

Downstream of #166, #167, and jenkinsci/jenkins#6165. Bumps the baseline to one containing jenkinsci/jenkins#6165 and migrates to Jakarta Mail.

@basil basil mentioned this pull request Jan 8, 2022
10 tasks
@basil basil force-pushed the javamail-migrate branch 2 times, most recently from c6a0024 to 8e2290b Compare January 9, 2022 15:51
pom.xml Outdated Show resolved Hide resolved
@jglick jglick marked this pull request as ready for review July 19, 2022 16:46
@jglick jglick enabled auto-merge July 19, 2022 16:46
@jglick jglick merged commit 82219ae into jenkinsci:master Jul 19, 2022
@basil basil deleted the javamail-migrate branch July 19, 2022 17:20
@basil
Copy link
Member Author

basil commented Jul 19, 2022

I think this should be released to avoid problems for people who have upgraded to Mailer 435.v79ef3972b_5c7 or later (which uses jakarta.mail imports).

@basil
Copy link
Member Author

basil commented Jul 19, 2022

See the release notes for Email Extension 2.90 for suggested messaging.

@jglick
Copy link
Member

jglick commented Jul 19, 2022

I think this should be released

Done: https://github.com/jenkinsci/workflow-basic-steps-plugin/releases/tag/980.v82219a_ed188e

avoid problems for people who have upgraded to Mailer 435.v79ef3972b_5c7 or later

Is there some specific sort of problem you would foresee?

the release notes for Email Extension 2.90

That seems to be specific to people using custom in-process Groovy scripting, which would not apply here.

Maybe that the signature of MimeMessageBuilder changed incompatibly?

@basil
Copy link
Member Author

basil commented Jul 19, 2022

Is there some specific sort of problem you would foresee?

Yes, I suspect the mail step of Pipeline: Basic Steps 975.v8d89b_e9579b_b_ would stop working on 2.332.x once Mailer is upgraded to 435.v79ef3972b_5c7, because Pipeline: Basic Steps 975.v8d89b_e9579b_b_ uses JavaMail and consumes this library from Mailer, which (as of 435.v79ef3972b_5c7) is providing that library under new imports, which Pipeline: Basic Steps doesn't consume until 980.v82219a_ed188e.

That seems to be specific to people using custom in-process Groovy scripting, which would not apply here.

What do you mean by "that"?

The "Jakarta imports" section is specific to people using custom Groovy scripting, which does not apply here.

The "Related plugin releases" section does apply here.

@jglick
Copy link
Member

jglick commented Jul 19, 2022

The "Related plugin releases" section does apply here.

OK, I updated https://github.com/jenkinsci/mailer-plugin/releases/tag/435.v79ef3972b_5c7 and https://github.com/jenkinsci/workflow-basic-steps-plugin/releases/tag/980.v82219a_ed188e accordingly; can you check for accuracy please?

@basil
Copy link
Member Author

basil commented Jul 19, 2022

Looks good to me

@jglick
Copy link
Member

jglick commented Jul 19, 2022

OK. I am preparing a bom update for this…

@basil
Copy link
Member Author

basil commented Jul 19, 2022

Beat you to it in jenkinsci/bom#1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants