Moved PushdStep to workflow-durable-task-step
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Feb 16, 2023
| .withCallback(BodyExecutionCallback.wrap(getContext())) | ||
| .start(); | ||
| return false; | ||
| throw new AssertionError("only deserialized"); |
There was a problem hiding this comment.
Did you test deserialization of the old execution with this PR?
There was a problem hiding this comment.
Yes, see testing notes in upstream.
There was a problem hiding this comment.
Ok great; It looks like I was reviewing the upstream PR at the same time you were adding the testing notes, so I did not see them before.
froque
added a commit
to jenkinsci/plugin-usage-plugin
that referenced
this pull request
Jun 28, 2023
Happend with org.jenkinsci.plugins.workflow.steps.PushdStep that was moved from workflow-basic-steps-plugin to org.jenkinsci.plugins.workflow.support.steps.PushdStep in workflow-durable-task-step-plugin jenkinsci/workflow-basic-steps-plugin#258 jenkinsci/workflow-durable-task-step-plugin#293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/workflow-durable-task-step-plugin#293.