JENKINS-61474 Improve null safety of the tool step

[duemir]

Tools page doesn't prevent submission of empty tool names. Some tools (e.g. Allure Commandline) use Util.fixEmptyAndTrim on the name, so there is a possibility of NPE when comparing the tool names. By flipping the comparison we avoid NPE since tool step requires name argument.

This most likely fixes https://issues.jenkins.io/browse/JENKINS-61474

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jtnord]

Some tools (e.g. Allure Commandline) use Util.fixEmptyAndTrim on the name

sounds like a UX bug should be filed for these plugins? How does that render / work in dropdowns etc...

[duemir]

@jtnord it is either shown as blank item if plugin stores it as empty string or as null:

[jtnord]

@jtnord it is either shown as blank item if plugin stores it as empty string or as null:

please file bugs for the plugins that support null or the blank string then that you are aware of (or a general one for Jenkins core to prevent this - but this would break those tools installation definitions if/when merged without plugin changes).