Log a note when catchError
sets build result
#308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it can be confusing why a build had the result that it did. Observed in a pipeline using the idiom
When the first pod is killed, the
node
block retried and the build ran to completion (FlowEndNode
set toSUCCESS
) yet theRun
is set toUNSTABLE
, which is what the step is supposed to do but unintentional here; the reason for thecatchError
was rather to work around an exit code of 1 from the mock load command due to mock test failures, which is better handled via jenkinsci/mock-load-builder-plugin#102.