[JENKINS-54323] Add setBuildInfo step #75
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-54323. Complements #71.
This PR adds a dedicated step named
setBuildInfo
(I don't feel too strongly about that name, so let me know if you'd prefer something else) for settingRun.description
,Run.displayName
,Run.keepLog
, andRun.result
. This step would get rid of one of the use cases that currently requiresRunWrapper
.Right now, I've created a single step that takes a specified
Describable
in its constructor:The other approach that would make sense to me would be to have a dedicated step for each field:
I chose the describable approach because I initially allowed a list to be passed to the step, but that didn't seem very likely to be useful in practice, so I simplified it, at which point a dedicated step for each field seems like the better approach. I'm putting this up as-is to see what people think, so let me know if you have a strong preference for either implementation.
@reviewbybees