Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent pom and core requirement #119

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Nov 4, 2021

Kind of a follow up of jenkinsci/jenkins#5320.

ping @car-roll

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -64,16 +64,16 @@
<properties>
<revision>2.22</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.277.1</jenkins.version>
<jenkins.version>2.303.1</jenkins.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.303 does seem like a big bump, but it does seem like the majority of users are on that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: jenkinsci/jenkins#5320 is first in 2.303.x as an LTS line, so this is not arbitrary.

Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.303.x line is the current LTS line, so I'd generally rather not force people to it, but there aren't other changes to be released. This seems fine to me.

@car-roll
Copy link
Contributor

car-roll commented Nov 4, 2021

Yikes, I accidentally bumped jenkins to 2.304 in #120, fixing here and reflecting change in logs

@jglick
Copy link
Member

jglick commented May 24, 2022

Kind of a follow up of jenkinsci/jenkins#5320.

@alecharp @car-roll can you explain in what sense this is a follow-up to that core change? This baseline is causing me some problems in handling #172 so I would like to know if it was truly necessary or if I can in fact revert the baseline to, say, 2.289.x at least for one release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants