Use non-deprecated lazily evaluated iterateEnclosingBlocks

[res0nance]

Signed-off-by: Raihaan Shouhell raihaan.shouhell@autodesk.com

Replacing the deprecated FlowScanningUtils.
See:
https://github.com/jenkinsci/workflow-api-plugin/blob/f21a0577338eecb418d9f354de600a1a509e84f9/src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScanningUtils.java#L113-L124

[dwnusbaum]

Rebuilding

[dwnusbaum]

I think the ExecutorStepTest.buildShellScriptAcrossRestart failure is similar to flakes investigated in #139, so I pushed a fix into #121 and will rebuild once that PR build passes and is merged.

[dwnusbaum]

Flaky Windows agent in the CI build, rebuilding:

Cannot contact aci-maven-windows-zrs99: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@600065fe:JNLP4-connect connection from 40.79.75.29/40.79.75.29:24577": Remote call on JNLP4-connect connection from 40.79.75.29/40.79.75.29:24577 failed. The channel is closing down or has closed down

[dwnusbaum]

Two test failures: ExecutorStepTest.contextualizeFreshFilePathAfterAgentReconnection (which I thought I fixed in #137... This time the test timed out, which is new at least. From a quick looks the problem is that we got here but not here) and ExecutorStepTest.reuseNodesWithDifferentLabelsFromPreviousRuns. Will try rebuilding.

[dwnusbaum]

Hmm, looks like the failures this time are the ones mentioned at the bottom of #139 (comment); I'll look into them.

[dwnusbaum]

79b5ef8 improves the tests so that failure messages will actually tell us what the difference is between the expected and actual behavior.

[dwnusbaum]

Well, the tests passed this time, and as far as I can tell the main change shouldn't have introduced any new flaky tests, so I am going to go ahead and merge the PR.