[JEP-210] Integration tests with DurableTaskStep #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
…cher works. (Test fails if the recoding is commented out; or if the watch overload is removed, reverting to old polling mode.)
jglick
added a commit
to jglick/logstash-plugin
that referenced
this pull request
Dec 7, 2016
4 tasks
jglick
commented
Feb 6, 2018
| } | ||
|
|
||
| @Override public void output(InputStream stream) throws Exception { | ||
| IOUtils.copy(stream, listener.getLogger()); |
There was a problem hiding this comment.
This needs to be interrupted somehow when stop is called.
…ote side, demonstrating that the BindingStep.Filter is operating there.
jglick
commented
Aug 25, 2018
| private static class RemotableBuildListener implements BuildListener { | ||
| private static final long serialVersionUID = 1; | ||
| /** actual implementation */ | ||
| private final TaskListener delegate; |
There was a problem hiding this comment.
Would be nice to have another test here too, which would produce a large volume of output, using a listener that did not delegate but wrote independently to a separate file, and use Channel.Listener.onRead/.onWrite to demonstrate that there is little traffic…unless you disable watch mode, as a control.
…ger can reduce Remoting traffic.
jglick
changed the title
dwnusbaum
approved these changes
Sep 28, 2018
orgi
pushed a commit
to orgi/workflow-durable-task-step-plugin
that referenced
this pull request
Nov 13, 2018
[JEP-210] Integration tests with DurableTaskStep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests for jenkinsci/workflow-job-plugin#27.
JEP-210
automated Unicode handling testinteractive Unicode handling test on WindowsBindingStepTestwith a remote loggerWithContainerStepTeston an agentprototype against Logstash: [JENKINS-38381] Pipeline remote build logging logstash-plugin#18