-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JEP-210] Integration tests with DurableTaskStep #21
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
…cher works. (Test fails if the recoding is commented out; or if the watch overload is removed, reverting to old polling mode.)
} | ||
|
||
@Override public void output(InputStream stream) throws Exception { | ||
IOUtils.copy(stream, listener.getLogger()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be interrupted somehow when stop
is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(from #63)
…ote side, demonstrating that the BindingStep.Filter is operating there.
private static class RemotableBuildListener implements BuildListener { | ||
private static final long serialVersionUID = 1; | ||
/** actual implementation */ | ||
private final TaskListener delegate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have another test here too, which would produce a large volume of output, using a listener that did not delegate but wrote independently to a separate file, and use Channel.Listener.onRead
/.onWrite
to demonstrate that there is little traffic…unless you disable watch mode, as a control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(resolved)
…ger can reduce Remoting traffic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, okay
[JEP-210] Integration tests with DurableTaskStep
Integration tests for jenkinsci/workflow-job-plugin#27.
JEP-210
automated Unicode handling testinteractive Unicode handling test on WindowsBindingStepTest
with a remote loggerWithContainerStepTest
on an agentprototype against Logstash: [JENKINS-38381] Pipeline remote build logging logstash-plugin#18