Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-210] Integration tests with DurableTaskStep #21

Merged
merged 47 commits into from
Oct 4, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 4, 2016

Integration tests for jenkinsci/workflow-job-plugin#27.

JEP-210

  • basic implementation passing existing tests
  • specific test of a remote log stream
  • automated Unicode handling test
  • interactive Unicode handling test on Windows
  • check BindingStepTest with a remote logger
  • check WithContainerStepTest on an agent
  • prototype against Logstash: [JENKINS-38381] Pipeline remote build logging logstash-plugin#18

@ghost
Copy link

ghost commented Oct 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

}

@Override public void output(InputStream stream) throws Exception {
IOUtils.copy(stream, listener.getLogger());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be interrupted somehow when stop is called.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(from #63)

private static class RemotableBuildListener implements BuildListener {
private static final long serialVersionUID = 1;
/** actual implementation */
private final TaskListener delegate;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have another test here too, which would produce a large volume of output, using a listener that did not delegate but wrote independently to a separate file, and use Channel.Listener.onRead/.onWrite to demonstrate that there is little traffic…unless you disable watch mode, as a control.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(resolved)

Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, okay

@jglick jglick changed the title [JEP-210] Remote log-friendly DurableTaskStep [JEP-210] Integration tests with DurableTaskStep Sep 13, 2018
@jglick jglick merged commit 3bf52a2 into jenkinsci:master Oct 4, 2018
@jglick jglick deleted the logs-JENKINS-38381 branch October 4, 2018 22:41
orgi pushed a commit to orgi/workflow-durable-task-step-plugin that referenced this pull request Nov 13, 2018
[JEP-210] Integration tests with DurableTaskStep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants