Consistently use sandbox for CpsFlowDefinitions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basil The GitHub UI kind of bugged out on me when I went to merge this, and now it says its conflicted. I'm not really sure what happened, but I don't think there should be any conflicts. I'll try to close and reopen to see if that does anything. |
|
Weird, it did get merged, see 488f87f, looks like some kind of concurrency issue. |
basil
pushed a commit
to basil/workflow-multibranch-plugin
that referenced
this pull request
Dec 16, 2019
Consistently use sandbox for CpsFlowDefinitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the test suite for this plugin, I noticed the
CpsFlowDefinitions in the tests don't consistently use the script security sandbox. Using the script security sandbox results in a more realistic environment given that the script security sandbox should always be enabled in production.In this change, I replaced any usages of the deprecated single-argument constructor for
CpsFlowDefinitionwith usages of the non-deprecated two-argument constructor, passing intrueas the second argument in order to always enable the script security sandbox.Note that I did not touch
ReplayActionTest#multibranch, which intentionally disables the script security sandbox for testing purposes.