Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve /usr/local in Home Assistant - binding to /data #1094

Merged
merged 5 commits into from
Jan 25, 2021

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented Jan 23, 2021

Description

Mount /data as /usr/local since Home Assistant does not allow to configure what volumes get mounted

Related Issue

#1087

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

@angelnu angelnu changed the title Ha user local preseve /usr/local in Home Assistant - binding to /data Jan 23, 2021
@angelnu angelnu changed the title preseve /usr/local in Home Assistant - binding to /data preserve /usr/local in Home Assistant - binding to /data Jan 23, 2021
@jens-maus
Copy link
Owner

Thanks. Can you please add a 'oci' platform check around that code in S06InitSystem? And IMHO it also would be good to add a check for the 'RUNNING_IN_HA' env variable you just added to config.json to differentiate between HA and non-HA docker use.

@jens-maus
Copy link
Owner

Thanks for adding the oci check. However, how can be check for the RUNNING_IN_HA env variable additional within the docker?

@angelnu
Copy link
Contributor Author

angelnu commented Jan 24, 2021

Added but let us check that the environment variable is indeed passed to the script - at least it is there when I exec into the container but we cannot test this until we have the new snapshot built.

@angelnu
Copy link
Contributor Author

angelnu commented Jan 24, 2021

@jens-maus - this failed due the missing PR fix you already merged to head. Rebasing on latest master

(cherry picked from commit 7b42f7c)
@angelnu
Copy link
Contributor Author

angelnu commented Jan 25, 2021

I cherry picked the fix for the deploy test so this PR can be tested overnight

@jens-maus jens-maus merged commit b19ca29 into jens-maus:master Jan 25, 2021
@angelnu angelnu deleted the ha_user_local branch January 25, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants