Ingress upgrade allows K8s 1.25 deployment #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angelnu Please review this PR as you are the K8s expert and are using it in production ;) |
angelnu
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
It looks good @jens-maus .
Mid term I would suggest to upgrade to the common library as these type of changes are covered and removes the boiler plate. If interested I would propose a PR.
Go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current helm chart does not allow deployments on Kubernetes 1.25 since Ingress definition uses outdated API version. This PR updates the Ingress definition accordingly and was successfully deployed on Kubernetes 1.25.
Related Issue
Types of changes
Alternate Designs
Possible Drawbacks
Verification Process
Release Notes
Contributing checklist