Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common helm chart #2026

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Use common helm chart #2026

merged 1 commit into from
Nov 16, 2022

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented Oct 30, 2022

Description

Remove the boiler plate of the Helm chart by using acommon library chart. This simplifies keeping up with Kubernetes changes.

As the library use an slightly different way of defining persistent volumes, users might need to adjust this section in their deployment.

Related Issue

NA

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

  1. Keep the boiler plate which requires more maintenance.
  2. Delete the dedicated Helm chart and just use the app template

Possible Drawbacks

Need users to adjust persistence settings.

Verification Process

Install upgraded chard and checked that data was still available and the boot messages were clean.

Release Notes

  • The helm chart has been upgraded to use acommon library chart. Please upgrade your persistence volume according to the docs

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

@jens-maus
Copy link
Owner

Thanks gor this PR. As users would have to adapt their installations and initial installs might work slightly different now, can you please add some additional documentation to our own wiki here in the github project? This would be great.

In addition, please check if the established github workflows in this project might require some adaptions to run properly.

@angelnu
Copy link
Contributor Author

angelnu commented Oct 30, 2022

Updating the wiki now.

The GitHub flows should still be the same as we are not changing how the chart is being built, just how it is implemented internally.

@jens-maus - wiki is upgraded so we should be ready to merge so we get a snapshot chart built by the GitHub workflow. I will keep an eye for any reported issues by users of the chart (if they do not ping me in the k8s-at-home discord anyway).

@jens-maus jens-maus merged commit c497098 into jens-maus:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants