Add webui patch to allow filtering via regex #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens-maus
requested changes
Nov 4, 2022
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
IT-VBFK
force-pushed
the
issue-2028
branch
2 times, most recently
from
586d636 to
d7dc14c
Compare
jp112sdl
reviewed
Nov 4, 2022
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
jp112sdl
reviewed
Nov 4, 2022
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
|
Something went completely wrong here.. I think the issue here is the file encoding. So: what encoding this files must have? Obviously not UTF8... |
IT-VBFK
force-pushed
the
issue-2028
branch
3 times, most recently
from
7b4b73a to
ca98804
Compare
IT-VBFK
requested review from
jens-maus and
jp112sdl
and removed request for
jens-maus
Encoding and line endings have to be kept the same like in the original file from eQ3 even thought eq3 mixes them in different files themselves. |
jens-maus
requested changes
Nov 11, 2022
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
IT-VBFK
commented
Nov 11, 2022
buildroot-external/patches/occu/0170-WebUI-RegexSearchInDeviceLists.patch
Outdated
Show resolved
Hide resolved
jens-maus
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2028
Description
Issue: #2028
Mit freundlicher Unterstützung von @jp112sdl☺️
Related Issue
Types of changes
Alternate Designs
Possible Drawbacks
Verification Process
Release Notes
Contributing checklist