fix: could not configure the pattern #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessor in order to process exactly the files defined by this supplied pattern.
Download
added a commit
to Download/i18nline
that referenced
this pull request
Nov 2, 2016
* Applied jenseng#18 * Upgraded dependencies * Use ulog for logging * Add some auto-config to use `src` and/or `lib` as directories if none were specified * Print some helpful info at startup * Print some more and more detailed progress info * Added a help screen to the CLI tool * Updated README.md, License info
Download
added a commit
to Download/i18nline
that referenced
this pull request
Nov 2, 2016
* Applied jenseng#18 * Upgraded dependencies * Use ulog for logging * Add some auto-config to use `src` and/or `lib` as directories if none were specified * Print some helpful info at startup * Print some more and more detailed progress info * Added a help screen to the CLI tool * Updated README.md, License info
|
@jenseng I think you should just apply this PR. It solves the issue in a simple way. Yes it's less flexible and does not support multiple processors, but it does solve a real problem with 18nliner without having to resort to writing plugins. I applied this fix in my fork and it does the job as promised. Also, if you are working on it anyway 😄 why not add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transmit the configured pattern (through the options) to the Processor in order to process exactly the files defined by this supplied pattern.