Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows 'fs' issue on webpack #17

Merged
merged 3 commits into from
Jun 11, 2015
Merged

Fix Windows 'fs' issue on webpack #17

merged 3 commits into from
Jun 11, 2015

Conversation

Celestz
Copy link
Contributor

@Celestz Celestz commented May 26, 2015

-- Added npm run build and npm run extract commands.
-- Added Japanese samples

@Celestz
Fix Windows 'fs' issue on webpack
45b35cd 
-- Added npm run build and npm run extract commands.
-- Added Japanese samples
@Celestz Celestz mentioned this pull request May 26, 2015
Closed
@jenseng
Copy link
Owner

jenseng commented May 26, 2015

Good stuff! One little suggestion re <option>, also I'd like to see if we can track down the fs/noParse stuff ... the smaller we can keep webpack.config.js, the better 😄

@Celestz
Copy link
Contributor Author

Celestz commented Jun 8, 2015

Updated to fit the little nuances.

jenseng added a commit that referenced this pull request Jun 11, 2015
@jenseng
Merge pull request #17 from Celestz/master
abad87d 
Fix Windows 'fs' issue on webpack
@jenseng jenseng merged commit abad87d into jenseng:master Jun 11, 2015
@jenseng
Copy link
Owner

jenseng commented Jun 11, 2015

awesome, thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Celestz @jenseng