Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don’t attempt to sort imports on git push (they must already be sorted) #851

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: don’t attempt to sort imports on git push (they must already be sorted) #851

merged 1 commit into from
Dec 26, 2024

Conversation

jenstroeger
Copy link
Owner

Turns out that the isort hook configuration here wants to run the isort hook at different times — so we pin it down to pre-commit only.

@jenstroeger jenstroeger requested a review from behnazh as a code owner December 9, 2024 14:15
@jenstroeger jenstroeger changed the base branch from main to staging December 10, 2024 04:31
@jenstroeger jenstroeger merged commit 7aa2f9d into staging Dec 26, 2024
15 checks passed
@jenstroeger jenstroeger deleted the no-isort-on-push branch December 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behnazh behnazh behnazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenstroeger @behnazh