A11y: add missing href attribute for manager main nav to ensure oncli…

…ck fires on keyboard navigation modxcms#16612
jenswittmann · Sep 23, 2024 · 24fb76d · 24fb76d
1 parent d3b4f32
commit 24fb76d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/manager/controllers/default/header.php b/manager/controllers/default/header.php
@@ -329,7 +329,7 @@ public function processSubMenus(&$output, array $menus = [])
  $attributes = ' href="?a='.$menu['action'].$menu['params'].'"';
  }
  if (!empty($menu['handler'])) {
- $attributes .= ' onclick="{literal} '.str_replace('"','\'',$menu['handler']).'{/literal} "';
+ $attributes .= ' href="javascript:;" onclick="{literal} '.str_replace('"','\'',$menu['handler']).'{/literal} "';
  }
  $menu['icon'] = $menu['icon'] ?? '';
  $smTpl .= '<a'.$attributes.' tabindex="0">'.$menu['text'].$menu['icon'].$description.'</a>'."\n";