Update JAX dependency constraint, and bump minor version number #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zombie-einstein
commented
Apr 25, 2024
zombie-einstein
commented
- Bump minimum JAX version to 0.4.12 to reflect changes in Refactor host_callback as it is deprecated since v0.4.26 #17
- Bump minor version prior to release
- Update poetry.lock dependencies
jeremiecoullon
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
It would be good to also update the readme to point to the correct callback docs.
But in any case this looks good!
Good spot, I updated the link, if you think the updated link makes sense? |
|
Nice I think the updated link is good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.