Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope filter to getClaims() #27

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

alecpl
Copy link
Contributor

@alecpl alecpl commented Aug 28, 2024

Fixes #22.

@jeremy379 jeremy379 merged commit 4a22ec9 into jeremy379:main Sep 9, 2024
3 checks passed
@coffe4u
Copy link
Contributor

coffe4u commented Sep 18, 2024

This introduces a breaking change. Anyone who implements the IdentityEntityInterface or Claimable interface will need to update the getClaims() method. This broke on production instances for us today.

@jeremy379
Copy link
Owner

I'll revert and introduce that change in a new version

@jeremy379
Copy link
Owner

After more check, I already used a 2.4.0 version (upgrading from 2.3.3)

You can force the version 2.3.*

I've also documented the breaking change.

@coffe4u
Copy link
Contributor

coffe4u commented Sep 19, 2024

I guess I was expecting Semantic Versioning. Increasing the middle number usually indicates new features. Breaking changes usually increases the first number. Not that big of a deal. I was able to fix it in my implementation in just a couple of minutes. Thanks for documenting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getClaims() for requested scopes only
3 participants