Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design doc for v0.1 #9

Open
jeremyBanks opened this issue Mar 8, 2021 · 0 comments · May be fixed by #3
Open

Update design doc for v0.1 #9

jeremyBanks opened this issue Mar 8, 2021 · 0 comments · May be fixed by #3
Assignees
@jeremyBanks
Labels
documentation Improvements or additions to documentation

Comments

@jeremyBanks
Copy link
Owner

The design doc for v0.1 needs to be updated to reflect some changes in the implementation, including:

  • ResultRows interface added (instead of just using AsyncGenerator | Generator).
  • .close()/.rollback()/..dispose() consistently aborting/cancelling ongoing activity instead of blocking for it.
  • A MySQL driver will be bundled.
  • Anywhere that they may want to explicitly specify types because our inference isn't working.
@jeremyBanks jeremyBanks added the documentation Improvements or additions to documentation label Mar 8, 2021
@jeremyBanks jeremyBanks self-assigned this Mar 8, 2021
@jeremyBanks jeremyBanks linked a pull request Mar 8, 2021 that will close this issue
Version 0.1 (initial release) #3
Draft
@jeremyBanks jeremyBanks changed the title Updated design doc for v0.1 Update design doc for v0.1 Mar 8, 2021
@halvardssm halvardssm mentioned this issue May 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyBanks jeremyBanks

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 0.1 (initial release) jeremyBanks/database
1 participant
@jeremyBanks