Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events props #113

Closed
kiki-le-singe opened this issue Jan 13, 2020 · 5 comments
Closed

Events props #113

kiki-le-singe opened this issue Jan 13, 2020 · 5 comments
Labels
🚀 New feature New feature or request

Comments

@kiki-le-singe
Copy link

Hello !

First, thank you for your project it's awesome !

I have a little question... Is it possible to use some props events like these ones :

  • onDragStart
  • onDragEnd
  • onBottomReached
  • ...

thanks for your time

@jeremybarbet
Copy link
Owner

jeremybarbet commented Jan 15, 2020

Hi, thanks for the feedback,

No it's not possible, but it would be definitely a good addition, you could maybe open a pull request if you are willing to make these changes,

cheers

@jeremybarbet jeremybarbet added the 🚀 New feature New feature or request label Jan 28, 2020
@jeremybarbet
Copy link
Owner

You have a new props available in version 1.3.7-rc.2 https://jeremybarbet.github.io/react-native-modalize/#/PROPSMETHODS?id=onpositionchange. Not all you asked, but a good first step

@kiki-le-singe
Copy link
Author

Thanks for your return. If i have time I will create a pull request.

onpositionchange is really interesting, a really good first step! Thanks!

@jeremybarbet
Copy link
Owner

Hi, I released a new rc-15 version with a new props for this. You can find the doc here and example here

Moreover, you can now use this Animated.Value to check the different states of the modal along with onPositionChange. I will close this issue, feel free to open a PR if you want to implement a specific new props!

@kiki-le-singe
Copy link
Author

Hi! It's great! Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 New feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants