ScrollView doesn't work with adjustToContentHeight

[kg-currenxie]

If you use adjustToContentHeight but the content is taller than the screen, the scrollView should work.

At the moment, I have to turn off adjustToContentHeight on certain modals that I think will be tall enough. But we'll have more dynamic content in some modals, so I won't know.

[jeremybarbet]

Ah crap, it was working before, probably I messed up somewhere, must be.

Which version are you using? I'll look at it

Edit: I tried it running latest version rc.8 and it works using adjustToContentHeight https://b.ueno.is/YEuAeoyy

[kg-currenxie]

react-native-modalize": "1.3.7-rc.4", too old?

[jeremybarbet]

Would you mind testing the latest? rc.8

[kg-currenxie]

Same with rc.8 :/

[jeremybarbet]

Can you reproduce the issue on an expo snack?

[jeremybarbet]

@kg-currenxie What’s the status on this issue?

[kg-currenxie]

Sorry, haven't had the time to create a reproducible thing yet :/ You can close the issue until then if you want to :)

[jeremybarbet]

No, it's totally fine to keep it open, I'm just curious to see, since I wasn't able to reproduce on my side.

[danilocanalle]

I got the same bug.
I need to set disableScrollIfPossible={false} to work the scroll here.

[danilocanalle]

Maybe I Know @jeremybarbet where is the problem.
I think that children that is not fixed components (like the @kg-currenxie example)
Content that needs to wait a function response,
Your Modal do not know the total height of the content and so disable the scroll.
Mine is the same thing, I Have a function inside the component:

<Modalize ref={popupModalRef} adjustToContentHeight > {getCurrentModal('component')} </Modalize>

It make senses?

[jeremybarbet]

@danilo900 I'm not sure if both issues are the same, but your case does make sense. I'm not sure how to handle that though. If you were able to create a repro snack it would be easier to debug.

[danilocanalle]

@jeremybarbet I Found out the problem

https://snack.expo.io/@bookplay/react-native-modalize-bug-height

The HeaderComponent is bugging the Modal on this situation.

Try on snack, with header its going to bug the scroll.
If you remove the header, its going to work perfectly.

:/

[jeremybarbet]

Good catch! Usage of XComponent was the culprit. It should be fixed now, I will release asap.

About the async function that loads data before showing up should be on a new separated issue

Edit: Released in 2.0.0

[kg-currenxie]

2.0.0 works 🎉 thanks <3

[danilocanalle]

Yeaaa, worked perfectly! @jeremybarbet you are awesome ! <3

About the async function, forget that, its working here :D
On my example it already was with the method that I said :)

[raheelCb]

same issue causing me in your current release

[danilocanalle]

Are you testing on Android?
I Got the error on Android, on iOS its ok.

Reported here:
#219

[raheelCb]

Yes I am testing on android

[raheelCb]

Are you testing on Android?
I Got the error on Android, on iOS its ok.

Reported here:
#219

One more issue I am facing is that when I load my component. If the content is more than the height, then it first automatically scroll up and then to the snap point where I have adjusted it to be on certain position

[danilocanalle]

Yes I am testing on android

Yea, so its related to my new issue. #219