Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position on orientation change #274

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

kotielnikov
Copy link
Contributor

Before:
(Goes out of the screen when switching to landscape mode)

After:
(Snaps to the right snappoint)

@jeremybarbet
Copy link
Owner

LGTM, thank you!

@jeremybarbet jeremybarbet merged commit f0d75ab into jeremybarbet:master Dec 3, 2020
@fortezhuo
Copy link
Contributor

Hi @kotielnikov and @jeremybarbet

This script will cause modalize always open while snapPoint set. Please review

React.useEffect(() => {
    if (lastSnapRef.current || (alwaysOpen && (modalHeightValue || adjustToContentHeight))) {
      handleAnimateOpen(alwaysOpen, lastSnapRef.current ? 'default' : undefined);
    }
    }
  }, [alwaysOpen, modalHeightValue])

jeremybarbet added a commit that referenced this pull request Dec 4, 2020
@jeremybarbet
Copy link
Owner

I deprecated 2.0.7 on npm, revert this commit and release 2.0.8. I don't have time to look at it to fix the code, @kotielnikov if you can look at it and create a new PR and testing it while the examples it would be lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants