Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback when closing modal #299

Merged

Conversation

maryjenel
Copy link
Contributor

With iOS 14, we were getting a bug when calling modalref.current.close() and displaying an Alert right after. There was a race condition. I added a call back for when the modal completely finished closing. We did not want to use a Timeout like here: facebook/react-native#10471

@grousseva
Copy link

How can I use this callback? I am having trouble :(

@jeremybarbet
Copy link
Owner

Looks good thanks, will tweak it a bit 👍

@jeremybarbet jeremybarbet merged commit f63feb4 into jeremybarbet:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants