feat: export useModalize from the root of the library #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhhayashi
changed the title
jeremybarbet
reviewed
Aug 3, 2022
docs/HOOKS.md
Outdated
|
|
||
| ```tsx | ||
| import React, { useRef } from 'react'; | ||
| import React from 'react'; | ||
| import { Modalize } from 'react-native-modalize'; |
There was a problem hiding this comment.
Should be possible to import from the root
Suggested change
| import { Modalize } from 'react-native-modalize'; | |
| import { Modalize, useModalize } from 'react-native-modalize'; |
There was a problem hiding this comment.
It didn't work for me and I didn't see anything in the code to make it export from the index file. Happy to PR a change to have it export from there if desired
There was a problem hiding this comment.
Oh I assume it was the case, probably missed that. You could add the export in there
jhhayashi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.