Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cookies/types): add 'None' as a valid sameSite value #164

Merged
merged 1 commit into from
Jan 1, 2023
Merged

feat(cookies/types): add 'None' as a valid sameSite value #164

merged 1 commit into from
Jan 1, 2023

Conversation

cameroncf
Copy link
Contributor

None is a valid value for SameSite and useful in certain cases.

None is a valid value for SameSite and useful in certain cases.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 286

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.613%

Totals Coverage Status
Change from base Build 285: 0.0%
Covered Lines: 594
Relevant Lines: 595

💛 - Coveralls

Base automatically changed from master to main March 24, 2021 15:04
@naorpeled naorpeled changed the title Adding 'None' to types as possible sameSite value feat(cookies/types): add 'None' as a valid sameSite value Jan 1, 2023
@naorpeled naorpeled merged commit 45dc229 into jeremydaly:main Jan 1, 2023
@naorpeled
Copy link
Collaborator

Hey @cameroncf,
good catch,
thanks for your contribution and sorry for the delayed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants