New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve error names even if code is bundled and class names are changed to avoid duplicates #205

Merged

naorpeled merged 2 commits into jeremydaly:main from Gamesome-ab:preserve-error-names

Dec 20, 2022

Contributor

a-game commented Apr 1, 2022

Closes #204

a-game added 2 commits

April 1, 2022 13:38


          Change error names to static strings.

3bdb7ff

Preserve error names even if code is bundled and class names are changed to avoid duplicates.


          Bump version

19d1491

naorpeled approved these changes

View reviewed changes

Collaborator

naorpeled commented Dec 20, 2022

Hey @a-game,
thanks for this PR, you're amazing.
I've encountered something similar in a different lib,
nice solution and good catch!!!

naorpeled merged commit b0c1f19 into jeremydaly:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet