Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type definition for Response.header #207

Merged

Conversation

XsnTrcK
Copy link

@XsnTrcK XsnTrcK commented Apr 14, 2022

Accurately type Response.header to describe what is possible to pass to the method

index.d.ts Outdated Show resolved Hide resolved
@naorpeled
Copy link
Collaborator

Hey @XsnTrcK,
thanks for this PR, you rock!

good catch :)

P.S: I added a small change, made the value field optional.

@naorpeled naorpeled merged commit 81b6d8b into jeremydaly:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants