Allowing passing a block to Warning.clear #20
Conversation
splattael
changed the title
| ignore = @ignore.dup | ||
| process = @process.dup | ||
| dedup = @dedup.dup | ||
| clear |
There was a problem hiding this comment.
I don't love the recursive call but it's convenient. Alternatively, we could move the clear logic into a private method clear_state or similar.
There was a problem hiding this comment.
This recursive call seems fine, considering it only recurses a single level.
| @process.clear | ||
| @dedup = false | ||
| # | ||
| # If a block is passed, the values are only cleared within the block and |
There was a problem hiding this comment.
This docs is kind of clumsy and needs to be improved 😅
| Warning.ignore(/.*/) | ||
|
|
||
| assert_warning '' do | ||
| Warning.warn 'foo' |
There was a problem hiding this comment.
I had to use Warning.warn because otherwise tests for Ruby 2.4 https://github.com/jeremyevans/ruby-warning/runs/7250088099?check_suite_focus=true would fail.
It's also worth noting that warn "foo" returns a newline while Warning.warn "foo" does not so no need to assert "foo\n".
I guess this is not related to this warning gem but the Ruby's Warning module:
$ irb
>> warn "foo"
foo
=> nil
>> Warning.warn "foo"
foo=> nilThere was a problem hiding this comment.
It's expected that Kernel#warn operates differently from Warning.warn, so this isn't an issue.
| def test_warning_clear_ignore | ||
| Warning.ignore(/.*/) | ||
|
|
||
| assert_warning '' do |
There was a problem hiding this comment.
To reduce horizontal space we could use:
| assert_warning '' do | |
| assert_warning('') { Warning.warn 'foo' } |
Not sure if this is compatible with the style of this gem though 🤷
There was a problem hiding this comment.
I think this is fine how it is.
If a block is passed, the values are only cleared within the block and restored after the block ends.
| def test_warning_clear_ignore | ||
| Warning.ignore(/.*/) | ||
|
|
||
| assert_warning '' do |
There was a problem hiding this comment.
I think this is fine how it is.
| Warning.ignore(/.*/) | ||
|
|
||
| assert_warning '' do | ||
| Warning.warn 'foo' |
There was a problem hiding this comment.
It's expected that Kernel#warn operates differently from Warning.warn, so this isn't an issue.
| ignore = @ignore.dup | ||
| process = @process.dup | ||
| dedup = @dedup.dup | ||
| clear |
There was a problem hiding this comment.
This recursive call seems fine, considering it only recurses a single level.
If a block is passed, the values are only cleared within the block and
restored after the block ends.
Fixes #18.