Add a check whether default_ignore file is empty during execution and ignores it if is #543
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #405 #542
Right now if the default ignore file
.dialyzer_ignore.exsis empty the task will bug out as per issue #542. This PR adds a check for file size, in case it is 0 it proceeds as if the file didn't exist and prints out an info message explaining that the file is empty.:ignore_warnings opt specified in mix.exs: .dialyzer_ignore.exs, but file is empty.Unfortunately, without my changes, the test suite is failing so I wasn't sure about adding a test for this, also my lack of in depth testing experience with Elixir.