Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor name conflict #26

Closed
solidevolution opened this issue May 6, 2015 · 9 comments
Closed

Vendor name conflict #26

solidevolution opened this issue May 6, 2015 · 9 comments

Comments

@solidevolution
Copy link

Hello,

since we use Slim Auth, we got the following error while composer install/update:

Skipped installation of bin bin/version-check for package jeremykendall/slim-auth: name conflicts with an existing file

Any idea?

@jeremykendall
Copy link
Owner

I think that should bin/version-check should probably be removed, I just haven't done it yet. That conflict will have no effect on the functionality. You can either

  • Ignore the conflict and use Slim Auth as normal
  • Take the extra step of removing it and submit a PR :-)

Thanks for reminding me that should go, and thanks for using Slim Auth! It's an honor to see this project in use in the wild.

@do3meli
Copy link
Contributor

do3meli commented Jan 3, 2016

Will you backport this and other changes to the slim-2.x branch?

@jeremykendall
Copy link
Owner

@do3meli Absolutely. I goofed up the commits I made last night when I was putting all of this together. I thought I'd successfully backported all the changes, but obviously I didn't 😦. Oops!

@jeremykendall
Copy link
Owner

@do3meli It looks like my goof was the other way around. All of the changes made it into the 2.x branch but no the 3.x branch. See the Oct 5 commits: https://github.com/jeremykendall/slim-auth/commits/slim-2.x

Am I missing something?

@do3meli
Copy link
Contributor

do3meli commented Jan 18, 2016

hmm @jeremykendall i think you still miss some commits yes. for example i am still seeing version_check in the bin directory when browsing the 2.x branch: https://github.com/jeremykendall/slim-auth/tree/slim-2.x/bin - mainly the commits you have done to the develop branch AFTER you merged my changes is missing in slim 2.x branch. (not all of them are really needed - all the 3.x specifics can stay where they are)

@jeremykendall
Copy link
Owner

Good catch! Just pushed the commit that remove /bin from the slim-2.x branch. Can you see any others I missed?

@jeremykendall
Copy link
Owner

@do3meli I think I got them all. Let me know if I missed anything else. Thanks!

@do3meli
Copy link
Contributor

do3meli commented Jan 19, 2016

hey @jeremykendall, thanks for the merge. i think you could even push these commits to the 2.x branch to keep it as close as possible to the develop branch:

72bb153
ef66012
9e8f520

but functionality wise i think you have covered everything now ;-)

thanks for your effort.
cheers dom

@jeremykendall
Copy link
Owner

Done! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants