Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Render NPM audit references as individual references #5547

Closed
aikebah opened this issue Mar 8, 2023 · 0 comments · Fixed by #5546
Closed

feat: Render NPM audit references as individual references #5547

aikebah opened this issue Mar 8, 2023 · 0 comments · Fixed by #5546
Milestone

Comments

@aikebah
Copy link
Collaborator

aikebah commented Mar 8, 2023

Currently in a reported finding from NPM Audit API the references section is mangled due to the format in which NPM Audit API is sending the references: a concatenation of <dash><space><reference-URL> strings delimited by \n (escaped newlines)

That concatenation is copied verbatim into the report as the reference.

Describe the solution you'd like

Have the report contain the individual lines of the references attribute, nicely hyperlinked in the HTML report so that the link can be followed for inspection

Describe alternatives you've considered

Leaving the report as-is, requiring users to copy/paste the URLs by hand.

Additional context
Current rendering:

Screenshot 2023-03-09 at 00 47 03

Proposed rendering:

Screenshot 2023-03-09 at 00 49 18

aikebah added a commit that referenced this issue Mar 8, 2023
@aikebah aikebah linked a pull request Mar 8, 2023 that will close this issue
@aikebah aikebah modified the milestone: 8.1.3 Mar 8, 2023
@aikebah aikebah added this to the 8.2.0 milestone Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant