Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional configuration for formatKotlin task to fail build if it cannot fix all lint errors #349

Merged
merged 14 commits into from
Nov 14, 2023

Conversation

acreddy9
Copy link
Contributor

Fix for issue #347.

Please see issue for explanation. The optional configuration mentioned is named failBuildWhenCannotAutoFormat.

@acreddy9 acreddy9 changed the title Optional configuration for formatKotlin task to fail build if it cannot fix all lint errors Added optional configuration for formatKotlin task to fail build if it cannot fix all lint errors Oct 23, 2023
@acreddy9 acreddy9 changed the title Added optional configuration for formatKotlin task to fail build if it cannot fix all lint errors Add optional configuration for formatKotlin task to fail build if it cannot fix all lint errors Oct 23, 2023
Copy link
Owner

@jeremymailen jeremymailen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I appreciate the solid implementation, documentation, and tests.

@jeremymailen jeremymailen merged commit 638e125 into jeremymailen:master Nov 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants