Retry interface implementation must exactly match (Azure#142)

fixes Azure#141
jeremymeng · Sep 25, 2018 · 7b7afb3 · 7b7afb3
1 parent 259d5a2
commit 7b7afb3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/retry/endpointDiscoveryRetryPolicy.ts b/src/retry/endpointDiscoveryRetryPolicy.ts
@@ -36,13 +36,17 @@ export class EndpointDiscoveryRetryPolicy implements IRetryPolicy {
    */
   public async shouldRetry(
     err: ErrorResponse,
-    retryContext: RetryContext,
-    locationEndpoint: string
+    retryContext?: RetryContext,
+    locationEndpoint?: string
   ): Promise<boolean | [boolean, string]> {
     if (!err) {
       return false;
     }
 
+    if (!retryContext || !locationEndpoint) {
+      return false;
+    }
+
     if (!this.globalEndpointManager.enableEndpointDiscovery) {
       return false;
     }

diff --git a/src/retry/sessionRetryPolicy.ts b/src/retry/sessionRetryPolicy.ts
@@ -34,11 +34,15 @@ export class SessionRetryPolicy implements IRetryPolicy {
    * @param {function} callback - The callback function which takes bool argument which specifies whether the request\
    * will be retried or not.
    */
-  public async shouldRetry(err: ErrorResponse, retryContext: RetryContext): Promise<boolean> {
+  public async shouldRetry(err: ErrorResponse, retryContext?: RetryContext): Promise<boolean> {
     if (!err) {
       return false;
     }
 
+    if (!retryContext) {
+      return false;
+    }
+
     if (!this.connectionPolicy.EnableEndpointDiscovery) {
       return false;
     }