Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for pull #1005 #1

Conversation

nedbat
Copy link

@nedbat nedbat commented Jun 30, 2020

This will make the current tests pass. We should also add new tests of the new behavior. I can take care of that after merging, or we can work on it together.

@nedbat
Copy link
Author

nedbat commented Jun 30, 2020

BTW: the logic here is that --sort only applies to the text report, so it shouldn't be passed to the other reporting functions.

@jerinpetergeorge
Copy link
Owner

This will make the current tests pass. We should also add new tests of the new behavior. I can take care of that after merging, or we can work on it together.

Great!!! Let us try together even though I am a noob to coveragepy source code

@jerinpetergeorge jerinpetergeorge merged commit 1fe2f58 into jerinpetergeorge:report-descending-sort-option Jun 30, 2020
@nedbat nedbat deleted the nedbat/1005 branch July 5, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants