Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add loading container for lighthouse scanning #304

Merged

Conversation

Zaphkiel-Ivanovna
Copy link
Contributor

πŸ“š Context

This PR improves the user experience by adding a loading component to display during the lighthouse scanning process.

✍️ Description

  • Added _buildLoadingComponent to show a CircularProgressIndicator, an icon, and helpful messages.
  • Updated the FutureBuilder to display the loading component while scanning.
  • Replaced the empty container previously used with the new loading UI.
  • Used ThemeData and Theming to ensure consistent styling.

πŸ§ͺ Testing

  1. Navigate to the main page.
  2. Start scanning and confirm the loading UI is displayed.
  3. Verify fallback content appears if no lighthouses are found.
  4. Test responsiveness across different devices and themes.
ScreenRecording_01-27-2025.20-48-26_1.MP4

* πŸ’„ ui: Introduce loading indicator with progress and icon
* πŸ’„ ui: Display scanning message with styling
* πŸ’„ ui: Update UI to show loading state instead of empty container
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 61.06%. Comparing base (54394cf) to head (dcd0638).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   61.06%   61.06%           
=======================================
  Files          35       35           
  Lines        1261     1261           
=======================================
  Hits          770      770           
  Misses        491      491           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Owner

@jeroen1602 jeroen1602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@jeroen1602 jeroen1602 merged commit 2dc0faf into jeroen1602:master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants