Fix \mb_convert_encoding error handling #207
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error thrown during converting value encoding from specified in VCF file to UTF-8 should be caught, but it is not, becouse since PHP 8.0.0
\mb_convert_encoding()
will throw\ValueError
(as mentioned in mb-convert-encoding-changelog) which inherits from\Error
, which inherits directly from\Throwable
, not\Exception
whichVCardParser
is curently catching.Currently VCF:
will throw error:
mb_convert_encoding(): Argument #3 ($from_encoding) contains invalid encoding "windows-1250"
which is not handled