Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \mb_convert_encoding error handling #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mateuszorzechowski
Copy link

Error thrown during converting value encoding from specified in VCF file to UTF-8 should be caught, but it is not, becouse since PHP 8.0.0 \mb_convert_encoding() will throw \ValueError (as mentioned in mb-convert-encoding-changelog) which inherits from \Error, which inherits directly from \Throwable, not \Exception which VCardParser is curently catching.

Currently VCF:

BEGIN:VCARD
...
N;CHARSET=windows-1250:Jacobsen;Thies-Tillman;;;
...

will throw error: mb_convert_encoding(): Argument #3 ($from_encoding) contains invalid encoding "windows-1250"
which is not handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants